Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to angular v15 #131

Merged
merged 5 commits into from
Feb 2, 2023
Merged

build: update to angular v15 #131

merged 5 commits into from
Feb 2, 2023

Conversation

chimurai
Copy link
Contributor

@chimurai chimurai commented Dec 21, 2022

Please check if the PR fulfills these requirements

  • The commit messages follow these
    guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other. Please describe:

If it is a Bugfix, please describe the root cause and what could have been done to prevent it…

What is the current behavior? (You can link to an open issue here, add screenshots…)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration
path for existing applications: …

Will need to be using Angular 15+

Other information (if applicable):


Please @mention @people to review this PR…

- npx browserslist@latest --update-db
- npx ng update @angular/core@14 @angular/cli@14 @angular-eslint/schematics@14 @nguniversal/express-engine@14 @nguniversal/builders@14 --force
- npm i -D ajv@latest core-js@latest
- npx ng update @angular/core@15 @angular/cli@15 @angular-eslint/schematics@15 @nguniversal/express-engine@15 @nguniversal/builders@15 --force
@chimurai chimurai changed the title Ng15 build: update to angular v15 Dec 21, 2022
@chimurai
Copy link
Contributor Author

  • updated ng13 to ng14
  • updated ng14 to ng15
  • updated circleci to use cimg/node with node v14.20.0
  • fixed sudo usage in .circleci/config.yml

- sudo usage prevented ENVIRONMENT variables being passed to scripts
@chimurai
Copy link
Contributor Author

👋 friendly ping to review the PR @willmendesneto

@willmendesneto
Copy link
Owner

That's amazing, @chimurai !

I'll check that in details tomorrow and I'll reply in here. Thanks for that, mate! <3

Copy link
Owner

@willmendesneto willmendesneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @chimurai ! Thanks for the contribution 🎉

@willmendesneto willmendesneto merged commit f0471dc into willmendesneto:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants