I want to update this file to fix angular 12 issue

[BruneXX]

The aim of this fix is to fix recently reported issue #79
please review and if it's ok and you can release a new version will be awesome.

Please check if the PR fulfills these requirements

• The commit messages follow these
  guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other. Please describe:

If it is a Bugfix, please describe the root cause and what could have been done to prevent it…

What is the current behavior? (You can link to an open issue here, add screenshots…)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

• Yes
• No

If this PR contains a breaking change, please describe the impact and migration
path for existing applications: …

Other information (if applicable):

---

Please @mention @people to review this PR…

[BruneXX]

Hi @willmendesneto when you have the chance please take a look at this PR, thanks! :)

[HunteRoi]

Hello there!

It looks like you have pushed a code change that does not meet the unit tests in place. Actually, you have edited the error message thrown when you give a wrong value to the appearance attribute of the ngx-skeleton-loader component. I see that you are trying to use line as the value for the appearance. Please beware that the line layout of the loader is its default value so you don't have to pass anything :

<ngx-skeleton-loader></ngx-skeleton-loader> <!-- will work -->
<ngx-skeleton-loader appearance=""></ngx-skeleton-loader> <!-- will work -->
<ngx-skeleton-loader appearance="circle"></ngx-skeleton-loader> <!-- will work -->
<ngx-skeleton-loader appearance="line"></ngx-skeleton-loader> <!-- will NOT work -->

However, with the changes from #77, the actual line value will be added for the appearance attribute. I'd then suggest you to wait for the PR to be completed and a new version released.

I wish you a great week-end!!

[BruneXX]

Hello there!

It looks like you have pushed a code change that does not meet the unit tests in place. Actually, you have edited the error message thrown when you give a wrong value to the appearance attribute of the ngx-skeleton-loader component. I see that you are trying to use line as the value for the appearance. Please beware that the line layout of the loader is its default value so you don't have to pass anything :

<ngx-skeleton-loader></ngx-skeleton-loader> <!-- will work -->
<ngx-skeleton-loader appearance=""></ngx-skeleton-loader> <!-- will work -->
<ngx-skeleton-loader appearance="circle"></ngx-skeleton-loader> <!-- will work -->
<ngx-skeleton-loader appearance="line"></ngx-skeleton-loader> <!-- will NOT work -->

However, with the changes from #77, the actual line value will be added for the appearance attribute. I'd then suggest you to wait for the PR to be completed and a new version released.

I wish you a great week-end!!

Hi @HunteRoi Sorry, I didn't see your PR and I didn't even know that were some unit tests.. I though that appearance='line' was Ok and the error was related to a missing code to include it.
I think you guys can get rid of my pull-request since the issue was in my code, thanks!

[willmendesneto]

Hi @BruneXX

line appearance is not accepted at the moment and it's documented here https://github.com/willmendesneto/ngx-skeleton-loader#appearance. So this is not a blocker to update to Angular v12.

As @HunteRoi mentioned, this appearance is in the process to be added in another pull request.

Saying that, I'm closing this pull request. Thanks @BruneXX for raising it and a new version of this package is coming soon with some good stuff, so stay tuned!