Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UNIX domain socket #255

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

albb0920
Copy link

This PR adds UNIX domain socket support for the addr option.

I want this as I run all my services behind nginx with unix domain socket.
I suppose there are more reasons someone would want to run
imageproxy without listening to a TCP port.

I never wrote any Go before this PR, I hope I haven't done anything stupid...

Allows listening to UNIX domain socket with the `-addr` option.
The syntax is `unix:path`. (same as NGINX `listen` directive)
@google-cla
Copy link

google-cla bot commented Dec 16, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #255 (bbb9aca) into main (c08b3c5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files           6        6           
  Lines         503      503           
=======================================
  Hits          439      439           
  Misses         36       36           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c08b3c5...bbb9aca. Read the comment docs.

@albb0920
Copy link
Author

@googlebot I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant