Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crappy SCP support #13

Closed
willnx opened this issue Aug 16, 2019 · 1 comment
Closed

Crappy SCP support #13

willnx opened this issue Aug 16, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@willnx
Copy link
Owner

willnx commented Aug 16, 2019

So, OpenSSH supports scp on the sink by executing something like this:
/path/to/shell -c <scp command>

I think I can even update ContainerShell to leverage that, and run scp inside the container. This would be really nice because the location of /srdata over SSH will be the same as SCP.

While I was digging around, I think I could even support WinSCP using SCP. WinSCP works just like scp when doing sftp, which is the default protocol (it just evokes the shell with the arg for sftp-server). However, to do SCP, WinSCP has this wonky protocol where it sends stuff to stdin and waits. The stuff looks like basic shell commands, so I can probably just read stdin, execute those commands inside the container, then barf the output back to WinSCP over stdout. If not, I could at least detect something is wrong send a message to the user, then tear everything down.

@willnx willnx self-assigned this Aug 16, 2019
@willnx willnx added the bug Something isn't working label Aug 16, 2019
@willnx willnx changed the title Crappy SSH support Crappy SCP support Aug 16, 2019
@willnx
Copy link
Owner Author

willnx commented Aug 20, 2019

I've figured out the source of this problem, it was in dockerpty. I forked and updated the code, and offered my changes back to them:
d11wtq/dockerpty#82

After spending a few days looking at the code, I'm just going to pull it into ContainerShell; no idea if they'll accept my changes, and it's been awhile since any PRs have been accepted.

@willnx willnx closed this as completed in 444fef2 Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant