Allow auxcov to be used by consumers that also use auxtools #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
commented
May 21, 2023
| @@ -100,3 +102,5 @@ fn stop_code_coverage(coverage_file: Value) { | |||
|
|
|||
| result | |||
| } | |||
|
|
|||
| pub fn anti_dce_stub() {} | |||
There was a problem hiding this comment.
I spent all night trying to figure out why it wasn't working and it turns out the entire crate was getting DCE'd.
This function needs to be called by the consumer to prevent that.
I have 0 clue why this is, it must be a bug in inventory.
Cyberboss
added a commit
to Cyberboss/auxlua
that referenced
this pull request
May 21, 2023
Call `anti_dce_stub()` in auxcov to prevent it from being eliminated entirely. `cargo update` pending willox/auxtools#72
Y0SH1M4S73R
pushed a commit
to tgstation/auxlua
that referenced
this pull request
May 22, 2023
* Fix the "coverage" feature. Call `anti_dce_stub()` in auxcov to prevent it from being eliminated entirely. `cargo update` pending willox/auxtools#72 * `cargo update`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.