Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/invalidate on remove #120

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Fix/invalidate on remove #120

merged 5 commits into from
Jan 4, 2024

Conversation

willscott
Copy link
Owner

#118 introduced the concept of handle invalidation, such that a handle involved in a rename would become stale if attempted to be used after the rename.
This extends that semantic to be also true on deletion.

@willscott
Copy link
Owner Author

  • I've updated the test to perform and validate renaming.
  • I also updated the test to demonstrate directory listings of more than the 1024 sized file handle cache of the caching handler

@willscott
Copy link
Owner Author

@DUOLabs333 - can you check if this set of updates works for your use case?

in particular, for the test to work I believe the correct expectation is to invalidate the handle of the removed file, rather than that of the containing directory as we had before. The client i'm using in the test was looking at the mtime of the directory to recognize that there's been a change at that level, which seems to indicate an expectation that the containing directory handle does remain valid across renames within it.

@DUOLabs333
Copy link
Contributor

It seems fine to me.

@willscott willscott merged commit 44f36ac into master Jan 4, 2024
4 checks passed
@willscott willscott deleted the fix/invalidate-on-remove branch January 4, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants