Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on USG 3P #8

Closed
dhutchison opened this issue May 8, 2022 · 5 comments · Fixed by #11
Closed

Not working on USG 3P #8

dhutchison opened this issue May 8, 2022 · 5 comments · Fixed by #11

Comments

@dhutchison
Copy link
Contributor

I'm not sure if the USG 3P is different from the UDM in protocol version, and if this is related/caused by #6 or #1.

From a bit of troubleshooting, it appears configuring the Server entry as in the docs that the request to the worker has the following:

"event": {
    "request": {
      "url": "https://ddns-updater.example.workers.dev/update?ip=%i&hostname=/nic/update?system=dyndns&hostname=mydomain.example.com&myip=111.111.111.111",

(Domain & IP replaced)

From a guess it looks like the USG doesn't support using a custom path on the URL.

Have I setup something wrong or is there a version difference somewhere?

@sholdee
Copy link

sholdee commented May 9, 2022

I am using commit 443ad14 with my ER4 because it doesn't require any of the extra parameters in the URL. I'm not really sure why that changed.

@dhutchison
Copy link
Contributor Author

Looking at #6 I think the newer devices use inadyn as their dynamic DNS client, while the USG 3P and a bunch of other devices use ddclient.

At a guess it sounds like the two of them are not exactly interchangeable.

@willswire what is your take? The way I see it there are two options for this project:

  1. Make it a lot clearer in the documentation what unifi devices this supports (or a commit to jump back to for older devices)
  2. Change the worker to be compatible with both clients (happy to help with a PR if this is the preferred direction)

@willswire
Copy link
Owner

@dhutchison perhaps making the worker compatible for both clients is best. I'd be happy to peer-review and help edit some code if you want to make a PR.

@willswire willswire pinned this issue May 17, 2022
@willswire willswire unpinned this issue May 23, 2022
dhutchison added a commit to dhutchison/unifi-cloudflare-ddns that referenced this issue May 23, 2022
@dhutchison
Copy link
Contributor Author

I've created PR #11 if you want to take a look. I've tested it with the device I have, but I could do with someone testing it still works on a UDM still.

I've deliberately not updated the readme to say the hosted version supports it just now, I'll leave that for you if you choose to deploy this version.

@AFink
Copy link

AFink commented May 24, 2022

I've created PR #11 if you want to take a look. I've tested it with the device I have, but I could do with someone testing it still works on a UDM still.

I've deliberately not updated the readme to say the hosted version supports it just now, I'll leave that for you if you choose to deploy this version.

It is working awesome. Thank you :D

willswire added a commit that referenced this issue May 26, 2022
feat: added support for ddclient based devices #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants