Change 200 OK return string to good
#10
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inadyn parses the 200 return string for "good", "nochg", "dnserr", "911", "badauth", and "nohost". All other strings result in "NOTOK". This small change fixes this.
|
FYI can confirm this fixes #7. 👍 from me, thank you. |
willswire
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inadyn parses the 200 return string for "good", "nochg", "dnserr", "911", "badauth", and "nohost". All other strings result in "NOTOK". This small change fixes this.
The UDM log before the change:
May 22 01:34:18 udm inadyn[10905]: Update forced for alias my.example.com, new IP# 1.2.3.4
May 22 01:34:18 udm inadyn[10905]: Fatal error in DDNS server response:
May 22 01:34:18 udm inadyn[10905]: [200 OK] DNS Record Update Successful!
May 22 01:34:18 udm inadyn[10905]: Error response from DDNS server, ignoring ...
After the change:
May 22 10:20:14 udm inadyn[18317]: Update forced for alias my.example.com, new IP# 1.2.3.4
May 22 10:20:14 udm inadyn[18317]: Updating cache for my.example.com