Added parameter to allow filtering using ORM filters #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilr
reviewed
May 21, 2024
src/Service/AlgoliaIndexer.php
Outdated
| @@ -162,8 +162,10 @@ public function exportAttributesFromObject($item) | |||
| 'objectCreated' => $item->dbObject('Created')->getTimestamp() | |||
| ]; | |||
|
|
|||
| if ($item->hasMethod('AbsoluteLink')) { | |||
| if ($item->hasMethod('AbsoluteLink') && !empty($item->AbsoluteLink())) { | |||
| $toIndex['objectLink'] = str_replace(['?stage=Stage', '?stage=Live'], '', $item->AbsoluteLink()); | |||
There was a problem hiding this comment.
This is going to call AbsoluteLink twice for every record indexing. While that can be a quick method it may also do quite a few look ups (subsite etc). Can we save the value to a value after the hasMethod $link = $item->AbsoluteLink(); and use that $link on the line below. Likewise for link.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchResultsmethodAlgoliaQuerierandexportAttributesFromObjectmethod onAlgoliaIndexer