Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .travis.yml and fix numpy-pandas dependency issue #60

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

peterstangl
Copy link
Collaborator

This PR updates the .travis.yml file (removes Python 3.5 and adds Python 3.8 and 3.9) and fixes a dependency issue between pandas and numpy by requiring numpy >= 1.16.5.

@coveralls
Copy link

coveralls commented Jan 4, 2021

Pull Request Test Coverage Report for Build 214

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.899%

Totals Coverage Status
Change from base Build 210: 0.0%
Covered Lines: 5634
Relevant Lines: 6267

💛 - Coveralls

@DavidMStraub
Copy link
Member

Strange, why would Travis install such an old numpy version (and only for 3.7, not for 3.6)?

@peterstangl
Copy link
Collaborator Author

Strange, why would Travis install such an old numpy version (and only for 3.7, not for 3.6)?

Yes, I also don't understand why Travis installs this numpy version with Python 3.7. In principle, this is not an issue of wilson and I'm not sure if it should be addressed in the setup.py. But on the other hand, it's very easy to fix and I think it doesn't hurt to require numpy >= 1.16.5.

@jasonaebischerGIT jasonaebischerGIT merged commit d94c4fb into wilson-eft:master Jan 22, 2021
@peterstangl peterstangl deleted the failingtests branch January 22, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants