Third CS and access PR (views) #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
pushed a commit
that referenced
this pull request
Oct 10, 2015
Fix also frontend and backend radio and checkboxes field.
wilsonge
pushed a commit
that referenced
this pull request
Jan 4, 2017
- Improved readability of assertions by using more appropriate assertions - Made some assertions more strict
wilsonge
pushed a commit
that referenced
this pull request
Jan 24, 2017
move jquery to vendor folder
wilsonge
pushed a commit
that referenced
this pull request
Jun 28, 2017
… (joomla#12294) * Cleanups, fixes and a bit of optimizations for site/components batch #5 - com_tags - com_users - com_wrapper Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole * Some more fixes after conflict resolution * - Changed some things according to reviewer's suggestions - Some more changes in updated stuff
wilsonge
pushed a commit
that referenced
this pull request
Dec 16, 2018
* This is a combination of 8 commits. This is the 1st commit message: > First WIP version of supporting nested subforms. This is the commit message #2: > Fix nested subforms not getting correct name attribute on input fields. This is the commit message #3: > Fix subform rows having invalid index, fix small typo. This is the commit message #4: > Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process. This is the commit message #5: > Implement feedback from PR at Joomla; > - Use a <template> HTML element for the template of the subform rows, > not a url encoded string inside of a <script> element. > - Fix code style errors reported by phpcs. > - Make the fixing of the unique attributes (name, id, etc) of input elements > of nested subform rows more errorprone, using the same method as the main > subform row. > - Manually add a minified version of the javascript file. This is the commit message #6: > Fix failing javascript tests due to changed structure of subform repeatable template container. This is the commit message #7: > Change subform repeatable javascript test to correctly check on > 0-indexed rows, previously they have been 1-indexed. This is the commit message #8: > Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly. > Additionally added a note why the fixScripts() method is broken and how it could get better. * Commit code styling errors and add an aria label for the outermost 'add' button. * Fix double group-add button on repeatable subform type.
wilsonge
pushed a commit
that referenced
this pull request
Apr 3, 2019
set logo above login form to height 70px
wilsonge
pushed a commit
that referenced
this pull request
Apr 3, 2019
logo gets width, so title is always over the content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wilsonge here is the third PR for the views and some missing things for the dispatcher