Use .form-select #55
Use .form-select #55
Conversation
|
LGTM. I did something similar without the XML conversion (which of course makes total sense). I assume you're missing the casseopia changes - but if you merge in my branch should be fine. |
|
@wilsonge should be good now! |
Co-authored-by: Quy <quy@fluxbb.org>
| @@ -33,7 +33,7 @@ body { | |||
| background: var(--atum-bg-light); | |||
| } | |||
|
|
|||
| .custom-select { | |||
| .form-select { | |||
| @@ -35,27 +35,23 @@ | |||
| } | |||
| } | |||
|
|
|||
| // All class names are duplicated custom select and form select for b/c with bootstrap 4 | |||
| &.custom-select-color-state, &.form-select-color-state { | |||
| &.form-select-success { | |||
There was a problem hiding this comment.
I thought we were leaving in the b/c mapping layer for 3rd parties? Looks like you removed them in the conflicts (same for the class below and casseopia)
There was a problem hiding this comment.
Apologies, I'm getting a bit confused here with some of the comments. These classes are of little use without #55 (comment)
I've re-added them with 57f096b
Also moved the extended .custom-select as it needs to be loaded before the custom CSS.
Tested both form-select and custom-select and both function correctly.
|
Thankyou very much! |
Converts to
form-selectin core.Allows the use of pre-bs5 classes in 3PD extensions (custom-select etc).