Cleanup -fno-addrsig use.

This is no longer necessary because we fixed the driver.

Test: ./checkbuild.py
Bug: android/ndk#884
Change-Id: I97682cbb6485cf5032079f21fa051a55888abd49

build/cmake/android.toolchain.cmake

@@ -477,9 +477,6 @@ if(ANDROID_ABI STREQUAL x86 AND ANDROID_PLATFORM_LEVEL LESS 24)
   list(APPEND ANDROID_COMPILER_FLAGS -mstackrealign)
 endif()
 
-# TODO: Remove when https://github.com/android-ndk/ndk/issues/884 is fixed.
-list(APPEND ANDROID_COMPILER_FLAGS -fno-addrsig)
-
 list(APPEND ANDROID_COMPILER_FLAGS -D_FORTIFY_SOURCE=2)
 
 # STL specific flags.

build/core/default-build-commands.mk

@@ -125,9 +125,6 @@ GLOBAL_CFLAGS += \
     -Wno-invalid-command-line-argument \
     -Wno-unused-command-line-argument \
 
-# TODO: Remove when https://github.com/android-ndk/ndk/issues/884 is fixed.
-GLOBAL_CFLAGS += -fno-addrsig
-
 GLOBAL_CFLAGS += -D_FORTIFY_SOURCE=2
 
 GLOBAL_LDFLAGS = \

build/tools/make_standalone_toolchain.py

@@ -133,9 +133,6 @@ def make_clang_scripts(install_dir, arch, api, windows):
     if arch == 'i686' and api < 24:
         flags += ' -mstackrealign'
 
-    # TODO: Remove when https://github.com/android-ndk/ndk/issues/884 is fixed.
-    flags += ' -fno-addrsig'
-
     cxx_flags = str(flags)
 
     clang_path = os.path.join(install_dir, 'bin/clang')

ndk/checkbuild.py

@@ -1787,9 +1787,6 @@ def write_clang_wrapper(install_dir: str, api: int, triple: str,
     if triple.startswith('i686') and api < 24:
         flags.append('-mstackrealign')
 
-    # TODO: Remove when https://github.com/android-ndk/ndk/issues/884 is fixed.
-    flags.append('-fno-addrsig')
-
     # Write shell scripts even for Windows to support WSL and Cygwin.
     write_clang_shell_script(wrapper_path, 'clang' + exe_suffix, flags)
     write_clang_shell_script(wrapperxx_path, 'clang++' + exe_suffix, flags)