Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview pane empty #75

Closed
mikepqr opened this issue Nov 14, 2020 · 5 comments
Closed

Preview pane empty #75

mikepqr opened this issue Nov 14, 2020 · 5 comments

Comments

@mikepqr
Copy link

mikepqr commented Nov 14, 2020

My preview pane is empty (i.e. the markdown files contain text, but the preview on the right hand side is blank). I'm using NVIM v0.5.0-d8c69ad (i.e. HEAD at the time of writing). Are there any additional dependencies or configuration steps I might be missing for working preview?

@wincent
Copy link
Owner

wincent commented Nov 14, 2020

I haven't seen this. Can you provide more details of your set-up? What is your config, where are the files on the disk, are there any symlinks or other oddities like network mounted drives involved etc?

@mikepqr
Copy link
Author

mikepqr commented Nov 14, 2020

By bisecting my config I figured out the problem: my colorscheme, iceberg.vim.

Corpus renders the preview as VertSplit, and iceberg.vim has the VertSplit background and foreground as the same color. Result: invisible previews!

So: problem solved from my POV. I have autocmd ColorScheme * highlight! link VertSplit Normal in my vimrc for now, and I'll keep an eye out for the change mentioned here.

It might make more sense, and seems less likely to cause problems like the one I had, if Corpus uses VertSplit for the separator between the list and preview, rather than for the preview itself. (Either that or use neovim's windowing features.)

@wincent
Copy link
Owner

wincent commented Nov 15, 2020

I believe 9d5de77 should do the trick.

@mikepqr
Copy link
Author

mikepqr commented Nov 16, 2020

Perfect, thanks!

(Just a nit, but I'd lean toward a different default. VertSplit is decoration so colorschemes are not designed with the expectation it it will be used to render text. It seems more likely than almost any other syntax group to be set up with very low or no contrast between fg and bg.)

@wincent
Copy link
Owner

wincent commented Jan 15, 2021

Just a nit, but I'd lean toward a different default. VertSplit is decoration so colorschemes are not designed with the expectation it it will be used to render text. It seems more likely than almost any other syntax group to be set up with very low or no contrast between fg and bg.

Just got an email from somebody wondering why they can't see the preview, so you may be right about that. I'm going to see if I can find a different default that looks reasonable out-of-the-box.

wincent added a commit that referenced this issue Jan 15, 2021
As suggested in:

    #75 (comment)

because:

> Just a nit, but I'd lean toward a different default. VertSplit is
> decoration so colorschemes are not designed with the expectation it
> it will be used to render text. It seems more likely than almost any
> other syntax group to be set up with very low or no contrast between
> fg and bg.

Switched to LineNr, semi-arbitrarily (there is no guaranteed highlight
group that is going to look good with all colorschemes, but this one
should at least not look invisible).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants