Added an if clause for all_status #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please try to adapt the readme accordingly. Increment minor version in package.json please |
|
Hi,
I updated the readme, upped the version to 10.13.6, and added a node in the
example code.
Sorry for the newbie question, but should I raise a pull request again?
…-Arvid
On Fri, Aug 11, 2023 at 4:30 PM Karl-Heinz Wind ***@***.***> wrote:
Please try to adapt the readme accordingly. Increment minor version in
package.json please
—
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFPAALHG6ZLSIAIRRVDQWF3XUY6YVANCNFSM6AAAAAA3M77EKE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks. I will do the review. No need for an additional pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shelly responds with a status for all devices when called with "all_status" instead of "status".
I added an if clause for "all_status" to the *.js. It is a slightly modified copy of the if clause for "status".
It works fine and you are welcome to pull it in if you wish.