Make it build again #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@winebarrel can you review, merge, and ideally cut a new release? without this change the gem is not install-able. |
|
i'm having trouble installing this on an M1 mac: any tips @h0tw1r3 ? |
|
related: jqlang/jq#2381 |
|
got the original fork working #19 (comment) |
|
@jakeonfire you're running into a bug in another gem unfortunately. It's related to git. |
|
@h0tw1r3 @jakeonfire please help me reproduce the problem you're seeing with the |
|
@flavorjones i don't have the setup around anymore from when i received that error (hence the lack of response - sorry). but i do disagree with @h0tw1r3's assertion that this is not installable on an M1 mac. i had to do a couple things to install the latest release (0.2.1) per #19 (comment) (using EnvironmentBundler Build MetadataGemfileGemfile# frozen_string_literal: true
source 'https://rubygems.org'
# Specify your gem's dependencies in ruby-jq.gemspec
gemspecGemfile.lockGemspecsruby-jq.gemspec# frozen_string_literal: true
lib = File.expand_path('lib', __dir__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require 'jq/version'
Gem::Specification.new do |spec|
spec.name = 'ruby-jq'
spec.version = JQ::VERSION
spec.author = 'winebarrel'
spec.email = 'sgwr_dts@yahoo.co.jp'
spec.description = 'Ruby bindings for jq'
spec.summary = 'Ruby bindings for jq'
spec.homepage = 'https://github.com/winebarrel/ruby-jq'
spec.license = 'MIT'
spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
spec.extensions = 'ext/extconf.rb'
# spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
# spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']
spec.required_ruby_version = '2.7'
spec.add_dependency 'multi_json'
spec.add_runtime_dependency 'mini_portile2', '>= 2.2.0'
spec.add_development_dependency 'rake'
spec.add_development_dependency 'rake-compiler'
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'
end |
Building against system libraries works on my system also, but the resulting build does not function correctly on an M1 mac (see issue #14). The build is broken when you do not use system libraries. which is what @flavorjones is referring to. |
|
gotcha. then reproduction steps are simply to follow the readme on an M1* mac, using bundler, rubygems, or trying from local source (w/o using system libraries). |
|
OK, the problem doesn't seem to be with mini_portile. I looked at the extconf file, and if I do those exact steps manually, I get the same failure that I get when I try to install the gem. Commands: result: Here's the complete shell session.Does that match what you're seeing? |
oniguruma regular expressions captures are not working properly when linked with ruby
|
i'm seeing: |
|
@jakeonfire looks like you are testing against the main branch, which does not include the changes in this pull request. I have responded to the PR flavorjones/mini_portile#119 on how to reproduce the mini_portile error. |
|
if i'm running wget https://github.com/stedolan/jq/archive/jq-1.6.tar.gz
tar -zxvf jq-1.6.tar.gz
cd jq-jq-1.6/
autoreconf -i
./configure --enable-shared --disable-maintainer-mode
makethen the branch isn't a factor, no? |
It is. mini_portile patch_files were added to this pull request. It's the only reason mini_portile is mentioned at all. The build errors you are posting are unrelated. |
|
@flavorjones as requested, please refer to flavorjones/mini_portile#119 for the steps to reproduce the mini_portile issue. |
|
Also had issues when upgrading to ruby 3.2. Not sure if it's related. Switched to this PR and installed completed successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archive changed to release as it includes the dependency for oniguruma. Otherwise a compile error occurs because the source does not exist in the jq/modules directory.
Changed autoreconf due to a known bug in the last jq release. jqlang/jq#1778