Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows native OpenSSH fix #451

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

manu0401
Copy link
Contributor

Windows native OpenSSH has alternative behavior for standard I/O descriptors, which can be selected through the OPENSSH_STDIO_MODE environement variable. Setting it to "nonsock" is required for sshfs compatibility.

See PowerShell/openssh-portable#759 for details.

Subitted upstream here
libfuse/sshfs#314

Windows native OpenSSH has alternative behavior for standard I/O
descriptors, which can be selected through the OPENSSH_STDIO_MODE
environement variable. Setting it to "nonsock" is required for
sshfs compatibility.

See PowerShell/openssh-portable#759
for details.

Subitted upstream here
libfuse/sshfs#314
@manu0401
Copy link
Contributor Author

I forgot to add this (along latest PowerShell/openssh-portable) will fix the infamous "read - ERROR from cb :87" that was reported at least in 6 PR:
https://github.com/winfsp/sshfs-win/issues?q=is%3Aissue+cb+%3A87

@billziss-gh
Copy link
Collaborator

billziss-gh commented Nov 20, 2024

This looks like a great solution to this problem. I am testing it now.

To clarify: this needs latest PowerShell/openssh-portable to work?

@billziss-gh
Copy link
Collaborator

billziss-gh commented Nov 20, 2024

I tried testing with the latest release of OpenSSH that I can find here: v9.8.1.0p1-Preview, but was not able to make it work.

Is your OpenSSH fix available somewhere for me to test?

EDIT: I see now that this has not been released yet as your OpenSSH commit was only added yesterday. Is this fix available somewhere or would I have to build OpenSSH from source?

@manu0401
Copy link
Contributor Author

For now you need to build from sources, as there is not yet any released binary. The build process is documented here https://github.com/PowerShell/openssh-portable/blob/latestw_all/contrib/win32/openssh/README.txt and works fine

You need to download Visual Studio Code.

I can also you an x64 ssh.exe binary with the change built-in.

@billziss-gh
Copy link
Collaborator

billziss-gh commented Nov 21, 2024

I can confirm that SSHFS with your changes together with patched SSH from PowerShell/openssh-portable works.

Screenshot 2024-11-21 140345

Thank you for submitting the PRs here and in PowerShell/openssh-portable, which fix a long-standing problem. I will be merging this PR.


FYI, I was able to build the PowerShell/openssh-portable project, but I had a couple of issues which I am documenting here in case you are more involved with that project:

@billziss-gh billziss-gh merged commit d5d0da9 into winfsp:master Nov 21, 2024
@manu0401
Copy link
Contributor Author

Upstream pull request in libfuse/sshfs has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants