Skip to content

Commit

Permalink
feat: make screen edge toggle overview rather than cycle between modes
Browse files Browse the repository at this point in the history
The user may have no usecase for the grid view mode, i.e. they may want
to activate overview, do their thing, and then return back to normal
desktop. However, with the current behavior, there's one extra step
(switch to grid mode) in order to go back to desktop.

In hindsight, we should have added different screen edge actions for
overview and grid modes. This can be done in 6.1.

BUG: 481335
  • Loading branch information
zzag authored and romangg committed Feb 24, 2024
1 parent 28671a3 commit fa7fb2a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion plugins/effects/overview/overvieweffect.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ int OverviewEffect::requestedEffectChainPosition() const
bool OverviewEffect::borderActivated(ElectricBorder border)
{
if (m_borderActivate.contains(border)) {
cycle();
m_overviewState->toggle();
return true;
}
return false;
Expand Down

0 comments on commit fa7fb2a

Please sign in to comment.