Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing includes #16

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Add some missing includes #16

merged 3 commits into from
Mar 5, 2024

Conversation

gfgit
Copy link
Contributor

@gfgit gfgit commented Mar 5, 2024

Hi, this fixes some compile errors on KDE Neon Developer with GCC 11.4
Also fix enum names changes on wlroots 0.18.0

@gfgit gfgit force-pushed the fix_includes branch 2 times, most recently from 7384708 to 02f8eb9 Compare March 5, 2024 12:49
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 50.00%. Comparing base (d7cd173) to head (17eb47b).

Files Patch % Lines
como/win/tabbox/tabbox.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   50.02%   50.00%   -0.02%     
==========================================
  Files         938      938              
  Lines       87251    87251              
  Branches    45478    45496      +18     
==========================================
- Hits        43647    43633      -14     
- Misses      38674    38719      +45     
+ Partials     4930     4899      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romangg
Copy link
Member

romangg commented Mar 5, 2024

Code changes look good. 👍 There is one more commit message to change.

Copy link
Member

@romangg romangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed there is a compile error. I believe it's about what I commented inline.

como/input/backend/wlroots/pointer.h Outdated Show resolved Hide resolved
@gfgit
Copy link
Contributor Author

gfgit commented Mar 5, 2024

Code changes look good. 👍 There is one more commit message to change.

Which commit?

@romangg
Copy link
Member

romangg commented Mar 5, 2024

Code changes look good. 👍 There is one more commit message to change.

Which commit?

You can see that usually in the job output of the failing job.

In this case the commit input: fix: use new wayland enums has body lines that are too long. Note that GitHub automatically folds too long lines. But if some dev later on tries to read the log on terminal it doesn't. To ensure readability of the git log, there is a max line length.

@romangg
Copy link
Member

romangg commented Mar 5, 2024

The clang-format job is failing: https://github.com/winft/como/actions/runs/8159949886/job/22305582476?pr=16

If you use VS Code, then it should automatically detect the clang-format config in IDE. Press Ctrl+Shift+I.

If you use Qt Creator there are few steps to do to setup a key combination: https://www.vikingsoftware.com/blog/using-clang-format-with-qtcreator/

@gfgit
Copy link
Contributor Author

gfgit commented Mar 5, 2024

The clang-format job is failing: https://github.com/winft/como/actions/runs/8159949886/job/22305582476?pr=16

If you use VS Code, then it should automatically detect the clang-format config in IDE. Press Ctrl+Shift+I.

If you use Qt Creator there are few steps to do to setup a key combination: https://www.vikingsoftware.com/blog/using-clang-format-with-qtcreator/

Thanks didn't know that!
Though now it's a bit weird with first argument not indented and others indented because of preprocessor macros

@romangg
Copy link
Member

romangg commented Mar 5, 2024

Yea, so my philosophy with code style is: better have it sometimes weird but always consistent. 😄

gfgit added 3 commits March 5, 2024 21:57
Introduce new WLR_HAVE_WL_POINTER_AXIS_SOURCE
switch to keep compatibility with wlroots < 0.18.0
@romangg romangg merged commit b7a040a into winft:master Mar 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants