-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some missing includes #16
Conversation
7384708
to
02f8eb9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 50.02% 50.00% -0.02%
==========================================
Files 938 938
Lines 87251 87251
Branches 45478 45496 +18
==========================================
- Hits 43647 43633 -14
- Misses 38674 38719 +45
+ Partials 4930 4899 -31 ☔ View full report in Codecov by Sentry. |
Code changes look good. 👍 There is one more commit message to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed there is a compile error. I believe it's about what I commented inline.
Which commit? |
You can see that usually in the job output of the failing job. In this case the commit |
The clang-format job is failing: https://github.com/winft/como/actions/runs/8159949886/job/22305582476?pr=16 If you use VS Code, then it should automatically detect the clang-format config in IDE. Press Ctrl+Shift+I. If you use Qt Creator there are few steps to do to setup a key combination: https://www.vikingsoftware.com/blog/using-clang-format-with-qtcreator/ |
Thanks didn't know that! |
Yea, so my philosophy with code style is: better have it sometimes weird but always consistent. 😄 |
Introduce new WLR_HAVE_WL_POINTER_AXIS_SOURCE switch to keep compatibility with wlroots < 0.18.0
Hi, this fixes some compile errors on KDE Neon Developer with GCC 11.4
Also fix enum names changes on wlroots 0.18.0