Fix react-website example #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tried deploying it to AWS and it works fine. |
|
That looks awesome @MichalMartinek! I've assigned @tsuf239 who originally developed the |
tsuf239
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran the react-website example, what happened was that the Wing Console kept refreshing over and over and was not usable at all. After trying to work around this via StaticWebsite and the custom OnDeploy function, I realized that it recompiles whenever a file in the folder or subdirectory where the main.w file itself is located changes. Wing in the case of React application changes the public/wing.js file after every deployment, causing another deployment in the old example. I've just changed the directory structure to keep the application in separate directory and it works.
Btw Create-react-app is deprecated, but it's working with Vite and Svelte with only few changes.