Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the bucket serve publicUrl and signedUrl using an express server on sim target #4143

Closed
tsuf239 opened this issue Sep 11, 2023 · 6 comments · Fixed by #7143
Closed
Labels
✨ enhancement New feature or request 🙋‍♀️ help wanted Extra attention is needed 🎨 sdk SDK

Comments

@tsuf239
Copy link
Contributor

tsuf239 commented Sep 11, 2023

Feature Spec

Strongly related to: #4137 (better to complete that one first/ during the work on this issue)
This task has two parts-

  1. Adding an express server to the bucket.inflight (the same way we do for the website and the api, the issue above suggest unifying it in some way)
  2. Implement the signedUrl method for the sim target:
    One way to do it will be:
  • In the signedUrl method, calculate the time it will be expired and hash it along in the key
  • Create an endpoint to serve the files- it should decode the URL to extract the key and expiry time, if the key was deleted already or the Date.now() is bigger than the expiry date- throw an error, otherwise serve the file (serving a deleted file should be added to the test)
    (any other ways are welcome!!)
  1. go to the publicUrl and signedUrl SDK spec tests and remove the condition skipping the sim target :)

Use Cases

signedUrl and publicUrl will work properly on the sim target.

Implementation Notes

No response

Component

SDK

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@tsuf239 tsuf239 added ✨ enhancement New feature or request 🙋‍♀️ help wanted Extra attention is needed labels Sep 11, 2023
@monadabot monadabot added this to Wing Sep 11, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New - not properly defined in Wing Sep 11, 2023
@tsuf239 tsuf239 mentioned this issue Sep 11, 2023
10 tasks
@staycoolcall911 staycoolcall911 moved this from 🆕 New - not properly defined to 🤝 Backlog - handoff to owners in Wing Sep 12, 2023
Copy link

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Nov 12, 2023
@tsuf239 tsuf239 removed the Stale label Nov 12, 2023
Copy link

Hi,

This issue hasn't seen activity in 60 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

Copy link

Hi,

This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

Copy link

Hi,

This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Jul 14, 2024
@tsuf239 tsuf239 removed the Stale label Jul 14, 2024
@Chriscbr
Copy link
Contributor

Chriscbr commented Sep 18, 2024

We recently added support for bucket signed URLs on the simulator, but when the bucket is public, the URL that the user used to upload the file can't also be used to view the file due to this limitation. Updating the existing express server we added so that it can also be used to view files (and updating the publicUrl method accordingly) should fix this.

@github-project-automation github-project-automation bot moved this from 🤝 Backlog - handoff to owners to ✅ Done in Wing Sep 18, 2024
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request 🙋‍♀️ help wanted Extra attention is needed 🎨 sdk SDK
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants