feat(sdk): add signed url

[kavinpanneer]

Stumbled on it while reading the docs and think it reads a bit better without the additional "a".

• Title matches Winglang's style guide
• Description explains motivation and solution
• Tests added (always)
• Docs updated (only required for features)
• Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Checklist

• Title matches Winglang's style guide
• Description explains motivation and solution
• Tests added (always)
• Docs updated (only required for features)
• Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

[revitalbarletz]

@subh-cs FYI.

[staycoolcall911]

Hey @kavinpanneer - can you please change the PR title according to these guidelines?

Also - the PR description has 2 checklists - can you please delete one and add a description of what your PR does?
Please include "Fixes #1383 " in your PR description - it will make sure that once the PR is merged, the issue will be closed.

[tsuf239]

The biggest part to be addressed is the signedUrl for the sim. Currently, it doesn't block access after expiring time, one way to solve it is
1- Create an express server to serve the publicUrl & signedUrl files, There is an issue with that, I'll attach the link soon,
2- In the signedUrl method, calculate the time it will be expired and hash it along in the key
3- Create an endpoint to serve the files- it should decode the URL to extract the key and expiry time, if the key was deleted already or the Date.now() is bigger than the expiry date- throw an error, otherwise serve the file (serving a deleted file should be added to the test)

Sorry for making the issue a bit more complicated, If you can think of an alternative approach, let me know :)
Also, please let me know if any help is needed!

Edit: decided to move the sim implementation to: #4143, so just the other little comments and you're ready to go!

[tsuf239]

I talked to @revitalbarletz, and we decided to decrease the scope of the task a little bit- so this issue will be for implementing the signedUrl method for the tf-aws target, and the implementation for the sim target will be a part of #4143 :)
for now please revert the changes for the sim- throw a "Not implemented yet" error in the inflight method, and conditionally skip the the assertion on the test written in wing (see

wing/examples/tests/sdk_tests/bucket/public_url.w

Lines 17 to 19 in 57a67cf

	if (util.env("WING_TARGET") != "sim") {
	assert(http.get(publicUrl).body == "Foo");
	}

)

[itssubhodiproy]

I think these are the few changes should be done, although I'm open discuss different approaches.

[tsuf239]

I think it's ready! 👏 👏 👏
let's take care of the merge conflict :)
(I'm checking if the tests pass on aws and will review again shortly)

[tsuf239]

@kavinpanneer it seems like you need to run pnpm install again in your working branch- the lockfile is conflicted
(then I'll be able to run the aws tests and approve if passes)

[tsuf239]

Approved! Great job!!

[tsuf239]

sdk tests are all passing:

[mergify]

Thanks for contributing, @kavinpanneer! This PR will now be added to the merge queue, or immediately merged if feat-sdk-signedurl is up-to-date with main and the queue is empty.

[monadabot]

Congrats! 🚀 This was released in Wing 0.34.14.