-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rfc: unphased
functions
#1711
Open
Chriscbr
wants to merge
17
commits into
main
Choose a base branch
from
rybickic/maybe-inflight
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
rfc: unphased
functions
#1711
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
645dd43
rfc: phase-independent functions with ?inflight keyword
Chriscbr 0f48be2
add resource example
Chriscbr 948bcf2
mention mutation
Chriscbr 7dbbb83
Merge branch 'main' into rybickic/maybe-inflight
Chriscbr 912e7c1
update syntax
Chriscbr d9908f3
update RFC
Chriscbr 103eab8
explain how array.map can work
Chriscbr a8601c6
clarify
Chriscbr 8827319
add note
Chriscbr 633d18a
fix typo
Chriscbr 4650e34
remove native class thing
Chriscbr cc3d63a
fix typo
Chriscbr 984a67d
Merge branch 'main' into rybickic/maybe-inflight
Chriscbr 23c067d
move to language-reference.md
Chriscbr d2ca05d
propose mechanism for unphased extern functions
Chriscbr 516641f
undo changes to RFC
Chriscbr ce3d292
simplify design slightly
Chriscbr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could also still accept a function, if both implementations are the same. I'm just trying to avoid clutter.
So it could be:
but also:
A simple check could be used to detect both cases:
exports.randomHex instanceof Function ? "single implementation" : "dual implementation"
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, this assumes externs can only be functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds ok to me as an extra enhancement (I probably wouldn't implement it for the MVP but maybe later).
Note: if you only provide a single function, it will need to be sync (not async), otherwise it can't be safely called in preflight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also FWIW possible to reuse a single implementation twice in the JavaScript (so I'm not sure it's worth slowing down performance by making it Wing's responsibility to check if externs are
instanceof Function
each time an extern is called).