-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): improve bucket tests readability with assertThrows
#3900
Conversation
assertthrows
assertthrows
@tsuf239 I tried to remove this: wing/examples/tests/sdk_tests/bucket/public_url.w Lines 28 to 31 in 2d1707c
But the fail ┌ public_url.wsim » root/env0/test:publicUrl
│ TypeError: fetch failed
│ at Object.fetch (node:internal/deps/undici/undici:11457:11)
│ at async Util.fetch (/tmp/wing-bundles-NFD9aL/index.js:1768:21)
│ at async $Closure1.handle (/tmp/wing-bundles-NFD9aL/index.js:114:26)
│ at async exports.handler (/tmp/wing-bundles-NFD9aL/index.js:5713:10)
│ at async Object.withTrace (/home/user/github/wing/libs/wingsdk/lib/testing/simulator.js:256:34)
│ at async TestRunnerClient.runTest (/home/user/github/wing/libs/wingsdk/lib/target-sim/test-runner.inflight.js:31:13)
│ at async testSimulator (/home/user/github/wing/apps/wing/dist/commands/test.js:214:22)
│ at async testOne (/home/user/github/wing/apps/wing/dist/commands/test.js:125:20)
│ at async testFile (/home/user/github/wing/apps/wing/dist/commands/test.js:55:39)
│ at async Promise.all (index 0)
│ at async Object.test (/home/user/github/wing/apps/wing/dist/commands/test.js:66:5)
└ at async Command.<anonymous> (/home/user/github/wing/apps/wing/dist/cli.js:46:30) |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Reopened the issue, thanks for reporting @garysassano! |
assertthrows
assertThrows
Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.29.1. |
Updating the bucket tests following the same standard used in the other resources.
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.