fix(sdk): add (back in) scope id to react app #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Console preview environment is available at https://wing-console-pr-5054.fly.dev 🚀 Last Updated (UTC) 2023-11-25 19:18 |
BenchmarksComparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2023-11-25 19:26 |
hasanaburayyan
approved these changes
Nov 25, 2023
|
Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if |
mergify bot
pushed a commit
that referenced
this pull request
Nov 25, 2023
…ct app (#5055) Followup to #5054 (Accidentally changed sim instead of tf-aws) Also follow up to #4993 (see topic.ts, reverted a change to call of `addPermissionToInvoke`) Ran failing AWS tests locally this time to verify fix *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
|
Congrats! 🚀 This was released in Wing 0.50.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See failing test here https://github.com/winglang/wing/actions/runs/6990660035/job/19020417470
Previous PR removed this as part of a larger effort to remove redundant ids (no functional reason to re-add your parents' id). This caused a test to fail, and I realized that in this case it is kinda useful to carry the name forward. So let's call this an exception.
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.