feat(sdk): let MutArray.push() accept variadic arguments of the same … #5114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type as the container's element type
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
Chriscbr
removed
the
⚠️ pr/review-mutation
|
Thanks for contributing, @autow0rk! This PR will now be added to the merge queue, or immediately merged if |
14 tasks
|
Congrats! 🚀 This was released in Wing 0.51.11. |
|
Hey @autow0rk, just wanted to let you know it looks like this didn't fix #4836 |
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
Fixes issue in #5114 and closes #4836 Attach updated array.ts file (has updated definition for .push() on MutArray to support variadic arguments) and update snapshots Example Input: let myList: MutArray<str> = MutArray<str> ["element1"]; myList.push("element2", "element3"); Example Output: const myList = ["element1"]; ((obj, args) => { obj.push(...args); })(myList, ["element2", "element3"]); ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4836
For the MutArray container type, the .push() method should take a variadic type. This is implemented in the type_check.rs file, by substituting a generic variadic argument type (T1) with the container's element type when typechecking the function arguments.
Checklist
Tests added (always)Snapshots for MutArray.push() were updated, not sure if new test cases need to be added for thispr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.