fix(compiler): can't reuse inflight closures

[yoav-steinberg]

See #4925
We can now code-gen inflight closures without construct id conflicts.

Checklist

• Title matches Winglang's style guide
• Description explains motivation and solution
• Tests added (always)
• Docs updated (only required for features)
• Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

[monadabot]

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic	Owner
Wing SDK and utility APIs	@chriscbr
Wing Console	@ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections	@hasanaburayyan
Platforms and plugins	@hasanaburayyan
Frontend resources (website, react, etc)	@tsuf239
Language design	@eladb
VSCode extension and language server	@markmcculloh
Compiler architecture, inflights, lifting	@yoav-steinberg
Wing Testing Framework	@tsuf239
Wing CLI	@markmcculloh
Build system, dev environment, releases	@markmcculloh
Library Ecosystem	@chriscbr
Documentation	@hasanaburayyan
SDK test suite	@tsuf239
Examples	@skorfmann
Wing Playground	@eladcon

[monadabot]

Benchmarks

Comparison to Baseline ⬜⬜🟥⬜⬜⬜🟥🟥🟥🟥⬜🟥⬜

Benchmark	Before	After	Change
version	75ms±3.28	73ms±0.38	-2ms (-2.83%)⬜
jsii_big.test.w -t sim	3336ms±19.03	3316ms±19.18	-20ms (-0.6%)⬜
jsii_big.test.w -t tf-aws	3416ms±20.9	3480ms±29.22	+64ms (+1.87%)🟥
functions_1.test.w -t sim	578ms±4.86	587ms±5.25	+8ms (+1.46%)⬜
functions_1.test.w -t tf-aws	1800ms±91.29	1821ms±81.12	+20ms (+1.14%)⬜
hello_world.test.w -t sim	582ms±5.19	593ms±5.81	+10ms (+1.79%)⬜
hello_world.test.w -t tf-aws	4462ms±32.47	4590ms±38.59	+127ms (+2.86%)🟥
functions_10.test.w -t sim	635ms±4.94	656ms±9.02	+21ms (+3.29%)🟥
functions_10.test.w -t tf-aws	4100ms±24.77	4235ms±36.04	+135ms (+3.3%)🟥
jsii_small.test.w -t sim	549ms±5.48	569ms±5.14	+19ms (+3.55%)🟥
jsii_small.test.w -t tf-aws	672ms±5.33	678ms±4.08	+6ms (+0.87%)⬜
empty.test.w -t sim	544ms±2.99	555ms±2.37	+11ms (+1.99%)🟥
empty.test.w -t tf-aws	663ms±5.09	673ms±7.07	+10ms (+1.55%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results

name	mean	min	max	moe	sd
version	73ms	72ms	74ms	0ms	1ms
jsii_big.test.w -t sim	3316ms	3295ms	3375ms	19ms	27ms
jsii_big.test.w -t tf-aws	3480ms	3421ms	3553ms	29ms	41ms
functions_1.test.w -t sim	587ms	577ms	601ms	5ms	7ms
functions_1.test.w -t tf-aws	1821ms	1696ms	2037ms	81ms	113ms
hello_world.test.w -t sim	593ms	576ms	602ms	6ms	8ms
hello_world.test.w -t tf-aws	4590ms	4495ms	4662ms	39ms	54ms
functions_10.test.w -t sim	656ms	639ms	684ms	9ms	13ms
functions_10.test.w -t tf-aws	4235ms	4158ms	4294ms	36ms	50ms
jsii_small.test.w -t sim	569ms	560ms	579ms	5ms	7ms
jsii_small.test.w -t tf-aws	678ms	671ms	687ms	4ms	6ms
empty.test.w -t sim	555ms	549ms	558ms	2ms	3ms
empty.test.w -t tf-aws	673ms	659ms	690ms	7ms	10ms

Last Updated (UTC) 2024-01-23 11:03

[mergify]

Thanks for contributing, @yoav-steinberg! This PR will now be added to the merge queue, or immediately merged if yoav/inflight_closure_autoid is up-to-date with main and the queue is empty.

[monadabot]

Congrats! 🚀 This was released in Wing 0.54.52.