Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): playwright install fails #6311

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

polamoros
Copy link
Contributor

@polamoros polamoros commented Apr 24, 2024

Running playwright install --with-deps fails because it executes apt update in the background, which is failing on the latest ubuntu-22.04 image release.

Related to Issue #9733.

Thanks to the temporary fix provided here 🙌.

Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@polamoros polamoros changed the title fix(ci): playwright install fails fix(console): playwright install fails Apr 24, 2024
@polamoros polamoros marked this pull request as ready for review April 24, 2024 11:15
@polamoros polamoros requested a review from a team as a code owner April 24, 2024 11:15
@monadabot
Copy link
Contributor

monadabot commented Apr 24, 2024

Console preview environment is available at https://wing-console-pr-6311.fly.dev 🚀

Last Updated (UTC) 2024-04-24 11:56

@monadabot
Copy link
Contributor

monadabot commented Apr 24, 2024

Benchmarks

Comparison to Baseline ⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 60ms±0.44 60ms±0.64 0ms (-0.08%)⬜
functions_1.test.w -t sim 404ms±17.65 403ms±4.73 -1ms (-0.26%)⬜
functions_1.test.w -t tf-aws 819ms±6.74 835ms±4.23 +15ms (+1.85%)🟥
jsii_big.test.w -t sim 2788ms±17.57 2827ms±22.38 +40ms (+1.42%)⬜
jsii_big.test.w -t tf-aws 3004ms±11.45 3012ms±12.79 +9ms (+0.29%)⬜
functions_10.test.w -t sim 492ms±15.34 501ms±13.81 +10ms (+1.96%)⬜
functions_10.test.w -t tf-aws 2043ms±17.73 2036ms±13.62 -7ms (-0.33%)⬜
jsii_small.test.w -t sim 377ms±4.09 372ms±5.84 -5ms (-1.26%)⬜
jsii_small.test.w -t tf-aws 612ms±5.08 606ms±3.74 -6ms (-0.96%)⬜
empty.test.w -t sim 363ms±7.54 369ms±7.12 +7ms (+1.84%)⬜
empty.test.w -t tf-aws 597ms±3.73 606ms±5.91 +8ms (+1.42%)⬜
hello_world.test.w -t sim 399ms±2.57 400ms±4.16 +1ms (+0.19%)⬜
hello_world.test.w -t tf-aws 1524ms±12.36 1529ms±19.17 +6ms (+0.37%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 59ms 62ms 1ms 1ms
functions_1.test.w -t sim 403ms 392ms 415ms 5ms 7ms
functions_1.test.w -t tf-aws 835ms 828ms 845ms 4ms 6ms
jsii_big.test.w -t sim 2827ms 2793ms 2887ms 22ms 31ms
jsii_big.test.w -t tf-aws 3012ms 2982ms 3050ms 13ms 18ms
functions_10.test.w -t sim 501ms 466ms 532ms 14ms 19ms
functions_10.test.w -t tf-aws 2036ms 2012ms 2074ms 14ms 19ms
jsii_small.test.w -t sim 372ms 365ms 389ms 6ms 8ms
jsii_small.test.w -t tf-aws 606ms 596ms 612ms 4ms 5ms
empty.test.w -t sim 369ms 356ms 388ms 7ms 10ms
empty.test.w -t tf-aws 606ms 586ms 617ms 6ms 8ms
hello_world.test.w -t sim 400ms 393ms 413ms 4ms 6ms
hello_world.test.w -t tf-aws 1529ms 1500ms 1593ms 19ms 27ms
Last Updated (UTC) 2024-04-24 12:01

@tsuf239
Copy link
Contributor

tsuf239 commented Apr 24, 2024

seems to fail:
image

Copy link
Contributor

mergify bot commented Apr 24, 2024

Thanks for contributing, @polamoros! This PR will now be added to the merge queue, or immediately merged if fix-playwright-install-error is up-to-date with main and the queue is empty.

mergify bot added a commit that referenced this pull request Apr 24, 2024
@mergify mergify bot merged commit 96dcfca into main Apr 24, 2024
15 checks passed
@mergify mergify bot deleted the fix-playwright-install-error branch April 24, 2024 12:14
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.72.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants