fix(compiler): closure transform generated parent_this even when not used
#6531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! 🎉
|
|
Console preview environment is available at https://wing-console-pr-6531.fly.dev 🚀 Last Updated (UTC) 2024-05-22 10:43 |
BenchmarksComparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-05-22 10:38 |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
yoav-steinberg
removed
the
⚠️ pr/review-mutation
5 tasks
Chriscbr
approved these changes
May 22, 2024
|
Thanks for contributing, @yoav-steinberg! This PR will now be added to the merge queue, or immediately merged if |
8 tasks
|
Congrats! 🚀 This was released in Wing 0.74.7. |
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2024
…6535) This is part of the effort to address #4925. Because inflight closures turn into class definitions, when they are passed to a `super()` call we use to get an error telling us that `super()` must be the first statement in a ctor. Now this is fixed: ```wing class Foo { new(x: num) {} } class Bar extends Foo { new() { class Baz {} // This is now ok super(1); } } ``` This PR also improves the diagnostics for mssing super calls or "not first statement" super calls. note: waiting for #6531 to be merged first. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small code cleanup as part of addressing #4925.
We only generate the
parent_thisvariable used in generated closure classes when needed. If the inflight closure never accessesthisthen we don't generatedparent_this. The code avoids traversing into inner classes inside the closure when searching forthisaccesses, making it a bit cleaner and more efficient.This relates to #4925 because it solves the problem of accessing
this(for assignment intoparent_this) before thesuper()call in a ctor.Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.