-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: @app
and @filename
intrinsics
#7078
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-7078.fly.dev 🚀 Last Updated (UTC) 2024-09-06 02:57 |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Mmm... I thought
But if you were to change it to:
Then the test can't be run on AWS, because in preflight it tries creating two buckets with the same scope and name. I'm not totally sure how to resolve this, so I'll revert a few of the changes and leave in |
@app
and @filename
intrinsics@app
and @filename
intrinsics
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
BenchmarksComparison to Baseline ⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-09-05 01:05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these need to be documented somewhere
@eladb missed that, thanks - I added it to the language ref |
Congrats! 🚀 This was released in Wing 0.84.3. |
Closes #6058
This PR introduces the
@app
and@filename
intrinsics to the language.@filename
is a complement to the existing@dirname
intrinsic, and@app
provides a way to access the globally accessible app.@app
exposes some meta information that can be useful, like whether the app is being compiled as a test or not, and the platform parameter system. In the CDK world, the app is also the "root" of the tree that all resources get added to.Checklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.