Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fs and util.exec examples do not work on windows #7193

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Chriscbr
Copy link
Contributor

Some of the examples from our docs don't currently work on Windows, causing them to fail our CI. This PR makes some adjustments to the examples so they should work on both platforms.

One of the issues is a Windows-related bug - I've reopened an issue for tracking it: #6915

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner October 10, 2024 02:43
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@Chriscbr Chriscbr changed the title chore: fix tests to work on windows chore: fix fs and util.exec examples do not work on windows Oct 10, 2024
@Chriscbr Chriscbr changed the title chore: fix fs and util.exec examples do not work on windows fix: fs and util.exec examples do not work on windows Oct 10, 2024
@Chriscbr Chriscbr merged commit 680d20f into main Oct 10, 2024
23 checks passed
@Chriscbr Chriscbr deleted the rybickic/fix-windows-tests branch October 10, 2024 03:16
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants