Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add clear() method for MutArray #7202

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

Pushkarm029
Copy link
Contributor

Checklist

Resolves #7139
This PR adds clear() method for MutArray.

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
@Pushkarm029 Pushkarm029 requested a review from a team as a code owner October 18, 2024 18:52
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

packages/@winglang/sdk/src/std/array.ts Outdated Show resolved Hide resolved
Co-authored-by: Elad Ben-Israel <eladb@wing.cloud>
@Pushkarm029 Pushkarm029 requested a review from eladb October 23, 2024 07:39
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 28, 2024
@eladb eladb removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Oct 28, 2024
Copy link
Contributor

mergify bot commented Oct 28, 2024

Thanks for contributing, @Pushkarm029! This PR will now be added to the merge queue, or immediately merged if clear_method is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 3e993ad into winglang:main Oct 28, 2024
13 checks passed
@Pushkarm029 Pushkarm029 deleted the clear_method branch October 28, 2024 08:33
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MutXxx.clear() methods
3 participants