Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update rust and wasi toolchain #7212

Merged
merged 11 commits into from
Nov 12, 2024
Merged

chore: update rust and wasi toolchain #7212

merged 11 commits into from
Nov 12, 2024
+18 −8

Conversation

Pushkarm029
Copy link
Contributor

Resolves #7175
This PR updates rust and wasi toolchain to latest.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Pushkarm029
init
bcf5247 
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
@Pushkarm029 Pushkarm029 requested a review from a team as a code owner October 31, 2024 16:08
@github-actions GitHub Actions
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping use over Discord.

@Pushkarm029
fix
326d84d 
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
eladb
eladb approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. @MarkMcCulloh if you are around to take a look, that will be great.

@Pushkarm029
Copy link
Contributor Author

Thanks, @eladb, for approving, but I think it still needs some work.

@eladb eladb self-requested a review October 31, 2024 16:54
@eladb
Copy link
Contributor

eladb commented Oct 31, 2024

@Pushkarm029 ping me when this is ready

MarkMcCulloh
MarkMcCulloh reviewed Oct 31, 2024
View reviewed changes
scripts/setup_wasi.sh Outdated Show resolved Hide resolved
.cargo/config.toml Show resolved Hide resolved
@eladb
Copy link
Contributor

eladb commented Nov 5, 2024

@Pushkarm029 let us know if you need any help

Pushkarm029 and others added 6 commits November 6, 2024 04:48
@Pushkarm029
fix
cb63058 
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
@Pushkarm029
fix
8a5d267 
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
@Pushkarm029
lint
d6b03a8 
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
@Pushkarm029
fix
3344496 
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
@monadabot
Merge branch 'main' into update_rust_wasm
67e0a5a
@monadabot
chore: self mutation (build.diff)
9d4fe0a 
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Nov 6, 2024
@Pushkarm029
Copy link
Contributor Author

@eladb, CI Green🟢. Looks good to go.

MarkMcCulloh
MarkMcCulloh reviewed Nov 6, 2024
View reviewed changes
.cargo/config.toml Outdated Show resolved Hide resolved
Pushkarm029 and others added 2 commits November 6, 2024 21:25
@Pushkarm029 @MarkMcCulloh
Update .cargo/config.toml
d8035b8 
Co-authored-by: Mark McCulloh <Mark.McCulloh@gmail.com>
@Pushkarm029
fix
757eff2 
Signed-off-by: Pushkar Mishra <pushkarmishra029@gmail.com>
MarkMcCulloh
MarkMcCulloh approved these changes Nov 10, 2024
View reviewed changes
scripts/setup_wasi.sh Show resolved Hide resolved
scripts/setup_wasi.sh Show resolved Hide resolved
@Pushkarm029
Copy link
Contributor Author

@eladb, We can merge this now.

@MarkMcCulloh
Copy link
Contributor

This PR should auto-merge if you remove the review-mutation label and resolve all the conversations

@eladb
Copy link
Contributor

eladb commented Nov 11, 2024

@Pushkarm029 can you please merge from main

@Pushkarm029
Copy link
Contributor Author

Done

@Pushkarm029 Pushkarm029 requested a review from eladb November 11, 2024 20:41
eladb
eladb approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@MarkMcCulloh
Copy link
Contributor

Heads up that the pr/review-mutation label needs to be removed in order to merge (see mergify rules here)

@Pushkarm029
Copy link
Contributor Author

@eladb, i think you can remove this label: pr/review-mutation.

@eladb eladb removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Nov 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024

Thanks for contributing, @Pushkarm029! This PR will now be added to the merge queue, or immediately merged if update_rust_wasm is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit c8aea62 into winglang:main Nov 12, 2024
13 checks passed
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.85.33.

@Pushkarm029 Pushkarm029 deleted the update_rust_wasm branch November 14, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCulloh MarkMcCulloh MarkMcCulloh approved these changes

@eladb eladb eladb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update rust and wasi versions
4 participants
@Pushkarm029 @eladb @MarkMcCulloh @monadabot