Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure extra opts per project #1423

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

DjLegolas
Copy link
Contributor

@DjLegolas DjLegolas commented Aug 31, 2024

Some users might want to be able to add additional options to the compilation command of each project.
With this, we add the --extra-opts build option which appends the passed option to a project's build command line.
The structure is:
--extra-opts <project>:<option>[;<option>...]

Closes: #1356

@DjLegolas DjLegolas force-pushed the add-extra-opts-param branch from 44cb569 to 113705d Compare August 31, 2024 09:23
@pbor
Copy link
Contributor

pbor commented Sep 2, 2024

I like the added functionality... however the proposed syntax is a bit weird :)

Is there some precedent we can copy from? how does meson allow to pass down per project specific options?

Some users might want to be able to add additional options to the
compilation command of each project.
With this, we add the `--extra-opts` build option which appends the
passed option to a project's build command line.
The structure is:
`--extra-opts <project>:<option>[;<option>...]`
@DjLegolas DjLegolas force-pushed the add-extra-opts-param branch from 113705d to 9eecd77 Compare September 2, 2024 18:23
@DjLegolas
Copy link
Contributor Author

however the proposed syntax is a bit weird :)

The syntax was fixed 😅 also I have rebased it.

Is there some precedent we can copy from?

I don't know if there is any place we can copy from. I tried to mimic the same functionality as with ninja_opts and cargo_opts.

how does meson allow to pass down per project specific options?

what do you mean?

@danyeaw danyeaw marked this pull request as ready for review January 6, 2025 21:14
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DjLegolas!

@danyeaw danyeaw merged commit aa21d8b into wingtk:main Jan 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow changing meson options for packages
3 participants