fix!: Parsing over a slice should invoke complete parsers #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the original
nom
design, users could mix and match complete/streaming parsers as needed. Now, they can't. This restores that ability by modifying the stream. As part of that, we apply this to two existing parsers,length_value
andParser::and_then
The problem is this comes with a 30% performance hit for partial parsing because we increased the size of the Stream (I benchmarked with
is_partial
returning a static value and no change). See #72 for fixing that.Despite the performance degradation, I'm going to merge this as this is necessary functionality for parsers to work correctly and we have #72 for improving the performance.