Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seq): 'seq' macro for easier skipping #238

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Conversation

epage
Copy link
Collaborator

@epage epage commented Apr 27, 2023

Fixes #82

examples/http/parser_streaming.rs Fixed Show fixed Hide fixed
examples/http/parser_streaming.rs Fixed Show fixed Hide fixed
src/macros.rs Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Apr 27, 2023

Pull Request Test Coverage Report for Build 5272674301

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.08%) to 49.184%

Files with Coverage Reduction New Missed Lines %
src/ascii/mod.rs 2 53.65%
src/macros.rs 5 61.9%
Totals Coverage Status
Change from base Build 5271793117: 0.08%
Covered Lines: 1236
Relevant Lines: 2513

💛 - Coveralls

@epage
Copy link
Collaborator Author

epage commented Apr 28, 2023

So I got seq!(Struct {}) working. The problem is with tuples. The only way I can find to make them work is if we do ().map which means we hit the performance problem of #237 which I was trying to avoid

src/macros/seq.rs Fixed Show fixed Hide fixed
src/macros/seq.rs Fixed Show fixed Hide fixed
src/macros/seq.rs Fixed Show fixed Hide fixed
src/macros/seq.rs Fixed Show fixed Hide fixed
src/macros/seq.rs Fixed Show fixed Hide fixed
src/macros/seq.rs Fixed Show fixed Hide fixed
src/macros/seq.rs Fixed Show fixed Hide fixed
src/macros/seq.rs Fixed Show fixed Hide fixed
@epage epage marked this pull request as ready for review December 18, 2023 21:45
@epage epage changed the title WIP: feat(seq): 'seq' macro for easier skipping feat(seq): 'seq' macro for easier skipping Dec 18, 2023
@epage epage merged commit 30ac3f8 into winnow-rs:main Dec 18, 2023
15 checks passed
@epage epage deleted the macro branch December 18, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An easier way to discard fields in a tuple
2 participants