perf(parser): Restore pre-consolidation performance #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#247 consolidated some of the parsers as suggested in #98 but there was a report of a slowdown from this change.
While this PR makes several changes, the core improvement is adding
#[inline(always)]
to theParser::parse_next
impls that we provide for users. I assume that created a barrier in the compiler so it couldn't optimize out the overhead fromtake_while
s dispatching. Somehow this only made a big difference with theascii::
parsers and not from direct uses oftake_while
.