Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream)!: Allow mutable iteration #274

Merged
merged 1 commit into from
Jul 6, 2023
Merged

feat(stream)!: Allow mutable iteration #274

merged 1 commit into from
Jul 6, 2023

Conversation

epage
Copy link
Collaborator

@epage epage commented Jul 6, 2023

This is a step towards #72

v0.4.7

json/basic/canada       time:   [10.272 ms 10.308 ms 10.347 ms]
json/verbose/canada     time:   [32.539 ms 32.714 ms 32.893 ms]
json/dispatch/canada    time:   [8.9747 ms 8.9926 ms 9.0118 ms]
json/streaming/canada   time:   [10.612 ms 10.667 ms 10.726 ms]

main (6747a8d)

json/basic/canada       time:   [10.234 ms 10.254 ms 10.274 ms]
json/unit/canada        time:   [9.5594 ms 9.5917 ms 9.6248 ms]
json/verbose/canada     time:   [30.371 ms 30.442 ms 30.517 ms]
json/dispatch/canada    time:   [8.8071 ms 8.8344 ms 8.8651 ms]
json/streaming/canada   time:   [9.7001 ms 9.7262 ms 9.7552 ms]

#274

json/basic/canada       time:   [10.231 ms 10.253 ms 10.279 ms]
json/unit/canada        time:   [9.3250 ms 9.3526 ms 9.3808 ms]
json/verbose/canada     time:   [29.832 ms 29.891 ms 29.957 ms]
json/dispatch/canada    time:   [8.4980 ms 8.5093 ms 8.5211 ms]
json/streaming/canada   time:   [10.007 ms 10.044 ms 10.081 ms]

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5476297501

  • 64 of 120 (53.33%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 50.832%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/binary/bits/mod.rs 3 4 75.0%
src/combinator/parser.rs 1 2 50.0%
src/token/mod.rs 13 14 92.86%
src/trace/internals.rs 0 1 0.0%
src/ascii/mod.rs 12 24 50.0%
src/stream/mod.rs 32 72 44.44%
Totals Coverage Status
Change from base Build 5448486419: 0.4%
Covered Lines: 1253
Relevant Lines: 2465

💛 - Coveralls

@epage epage merged commit 0625541 into winnow-rs:main Jul 6, 2023
14 checks passed
@epage epage deleted the p1 branch July 6, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants