Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stream)!: Avoid cloning Tokens #290

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(stream)!: Avoid cloning Tokens #290

wants to merge 1 commit into from

Conversation

epage
Copy link
Collaborator

@epage epage commented Jul 13, 2023

This was inspired by #232

@epage epage marked this pull request as draft July 13, 2023 17:19
@epage epage force-pushed the token branch 2 times, most recently from 732f985 to f57337c Compare October 13, 2023 21:41
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6513333155

  • 9 of 17 (52.94%) changed or added relevant lines in 3 files are covered.
  • 114 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 44.786%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ascii/mod.rs 6 9 66.67%
src/stream/mod.rs 2 7 28.57%
Files with Coverage Reduction New Missed Lines %
src/token/mod.rs 14 86.09%
src/ascii/mod.rs 100 53.28%
Totals Coverage Status
Change from base Build 6509683498: 0.4%
Covered Lines: 1181
Relevant Lines: 2637
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epage @coveralls