Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Give example of a non-generic signature #486

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 28, 2024

Trying to balance documentation-overload with helping new users who might be uncomfortable with the generics. Was a bit hesitant if this met that balance but my mastadon poll seemed to be in favor.

  • Didn't do this to parsers like opt or repeat where there is nothing concrete to work with
  • Skipped binary because that is a lot of repetition that I didn't want to take on atm

@epage epage marked this pull request as draft February 28, 2024 01:36
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (aaed6ae) to head (dc41fcd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   41.82%   41.85%   +0.03%     
==========================================
  Files          18       18              
  Lines        3046     3046              
==========================================
+ Hits         1274     1275       +1     
+ Misses       1772     1771       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8101333327

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 41.858%

Totals Coverage Status
Change from base Build 8083360033: 0.03%
Covered Lines: 1275
Relevant Lines: 3046

💛 - Coveralls

@epage epage force-pushed the docs branch 2 times, most recently from eb903da to dc41fcd Compare February 29, 2024 19:09
@epage epage marked this pull request as ready for review February 29, 2024 19:10
@epage epage merged commit d54e2ac into winnow-rs:main Feb 29, 2024
17 checks passed
@epage epage deleted the docs branch February 29, 2024 19:14
@epage epage mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants