Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(seq)!: Allow borrowing of parsers in seq #505

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix(seq)!: Allow borrowing of parsers in seq #505

merged 2 commits into from
Jan 3, 2025

Conversation

epage
Copy link
Collaborator

@epage epage commented Apr 9, 2024 •
edited
Loading

Fixes #502

BREAKING CHANGE: When using seq!(<tuple>), any local parsers must be
marked as mut

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8622080167

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 41.844%
Totals Coverage Status
Change from base Build 8541132511: 0.03%
Covered Lines: 1275
Relevant Lines: 3047
💛 - Coveralls

@epage epage marked this pull request as draft April 9, 2024 20:50
@epage epage added the M-breaking-change Meta: Implementing or merging this will introduce a breaking change. label Apr 9, 2024
epage added 2 commits January 3, 2025 11:00
@epage
test(comb): Show seq structs can borrow parsers
fc701b3
@epage
fix(seq)!: Allow borrowing of parsers in seq
2fd3833 
Fixes winnow-rs#502

BREAKING CHANGE: When using `seq!(<tuple>)`, any local parsers must be
marked as `mut`
@epage epage changed the title fix(comb): Allow seq tuples to borrow parsers fix(seq)!: Allow borrowing of parsers in seq Jan 3, 2025
@epage epage marked this pull request as ready for review January 3, 2025 17:20
@epage epage enabled auto-merge January 3, 2025 17:22
@epage epage merged commit f3e8d45 into winnow-rs:main Jan 3, 2025
16 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12601362333

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 40.989%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/macros/seq.rs 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
src/stream/mod.rs 1 24.7%
Totals Coverage Status
Change from base Build 12601155661: -0.07%
Covered Lines: 1276
Relevant Lines: 3113
💛 - Coveralls

@epage epage mentioned this pull request Jan 3, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seq! for tuples errors when capturing locally-defined parsers.
2 participants
@epage @coveralls