Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix pingcap#22301 and pingcap#33056
What is changed and how it works?
22301: having and order-by clause will append additional select fields into original select. there are some difference:
for having: the direct expr/col should be limited with only-full-group-by
for order by: the direct expr/col should be limited with only-full-group-by when group-cols are NOT empty.
for both: the base col extracted from these clause don't have to be checked with only-full-group-by
33056: inner join with using will hide some col, which cause the agg can't find it with there is a selection above the join; besides, FD in selection should also take into consideration of this kind of full schema, otherwise, will wrongly project out some column'FD, for example here, t2.a
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansible
repository