Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme fixes and enhancements #2231

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

DartVanya
Copy link
Contributor

@DartVanya DartVanya commented Oct 7, 2024

Full DarkMode support for TaskDialog

Credits to https://github.com/SFTRS/DarkTaskDialog

  • Fix artefacts on GroupBox and Static picture controls when window moving back from off-screen.

  • TreeNew: significantly improve visibility of selected item.

  • ExtListVew: fix text readability for hot and selected colored items.

  • Fix drawing of disabled ListView in dark theme Hide ListVIew on Graph settings page instead of disabling.

  • Fix multiline edit artifacts when typing, fix scrollbar.

  • Apply DarkMode_Explorer theme for all checkboxes (even for ListView checks).

  • Fix dark theme for new choose dialog.

  • Fix dark ListView header in Advanced Security and Digital Signature Details dialogs (skip superclass drawing)

  • Add borders to TabControl header and body, selected tab slightly enlarged (behaves like default MS white theme).

  • Add separators for StatusBar parts for better readability.

  • SysLink theme support (call PhInitializeSysLinkTheme to apply to control).

  • Add new theme options: EnableThemeAnimation (default 1), EnableThemeNativeButtons (default 0).


  • Advanced options: menu Reset added (support multiple selection).
  • Highlighting and Graph colors: menu - Reset added.

All changes highlighted on video:

before.mp4
after.mp4
taskdialog-dm.mp4
colors-menu-reset.mp4

- Advanced options menu Reset added
Credits to https://github.com/SFTRS/DarkTaskDialog
- Highlighting and Graph colors: menu - Reset added
- Fix drawing of disabled ListView in dark theme
- SysLink theme support (call PhInitializeSysLinkTheme to apply to control)
- Removed ListView subclass
- Add options: EnableThemeAnimation (default 1), EnableThemeNativeButtons (default 0)
- Fix the annoying white border what remained from the previous active control in CHECKLIST_ACLUI
- ExtendedServices: MessageBox to TaskDialog transit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants