Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query Interface (logger.query(options,callback)) not available on Version 4.2.1 #255

Closed
Bussinho opened this issue Nov 15, 2019 · 2 comments

Comments

@Bussinho
Copy link

Hello Guys,

for our project we need the function:
query(options?: QueryOptions, callback?: (err: Error, results: any) => void): any;

In the version 4.2.1 there is no function like this, so we get en undefined error.

Is there an other way to handle the query interface?

We have therefore version 3.8.0 installed.

@mattberther
Copy link
Member

winston-daily-rotate-file@4 removed support for winston@2 and the transport interfaces provided by it. As a result, the query method was removed. You can review the implementation starting at c1d1a3a#diff-5d4b74ff1561d45e3881ca3ae6a11f77L162 and could consider incorporating a variation of it into your project.

@dplewis
Copy link
Contributor

dplewis commented Dec 8, 2019

the transport interfaces provided by it. As a result, the query method was removed.

Query doesn't look like it rely on winston (maybe normalizeQuery but that just sets default options).

Is it possible to add it back? I can open a PR that will work without the winston dependencies.

dplewis added a commit to dplewis/winston-daily-rotate-file that referenced this issue Dec 9, 2019
mattberther pushed a commit that referenced this issue Dec 13, 2019
Apollon77 pushed a commit to Apollon77/winston-daily-rotate-file that referenced this issue Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants