Remove unused dependency "cycle" #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"cycle" is unused and appears to be unmaintained with no updates the last six years. It does not have a license specified in package.json so projects that use license checkers have a problem using winston-syslog due to the presence of cycle. The "cycle" module has ignored issues and pull requests to address the missing license issue. * dscape/cycle#21 * dscape/cycle#26
|
@DABH , thanks for the quick response! When do you anticipate to release a new version of winston-syslog with this change in it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"cycle" is unused and appears to be unmaintained with no updates the
last six years. It does not have a license specified in package.json
so projects that use license checkers have a problem using
winston-syslog due to the presence of cycle.
The "cycle" module has ignored issues and pull requests to address the
missing license issue.