[Bug]: on not working (or at least not as expected or misleading documentation)

[nopeless]

🔎 Search Terms

on error

The problem

logger.on event callbacks are not fired

This example can be found in the README.md (.on("error"))

I read some of winston's code base and found out that Logger ultimately derives from streams, which are known to be event emitters. Perhaps .on("error") is not when a logger is called with an error, but when there is an internal stream error

Nonetheless, either the code is wrong or the documentation is misleading

What version of Winston presents the issue?

3.7.2

What version of Node are you using?

v16.13.1

If this worked in a previous version of Winston, which was it?

No response

Minimum Working Example

import { default as winston } from "winston";

const logger = winston.createLogger({
    transports: [
      new winston.transports.Console({
        stderrLevels: [`error`],
      }),
    ],});

logger.on("error", err => {
  console.log("CALLBACK CALLED");
})

logger.error('what');

Additional information

No response

[wbt]

My understanding is that that callback was only for errors originating in the logger itself.
I opened a PR for your review; do you think it adequately addresses the issue?

[nopeless]

@wbt yes you understood it correctly

thanks for addressing the issue