Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pem keys? #701

Closed
nikolas opened this issue Aug 27, 2015 · 1 comment
Closed

Remove pem keys? #701

nikolas opened this issue Aug 27, 2015 · 1 comment

Comments

@nikolas
Copy link
Contributor

nikolas commented Aug 27, 2015

I'm making a Google Chrome extension, and when I install my node dependencies in
the extension's directory for testing purposes, I get the error:

This extension includes the key file '/home/nnyby/src/mediathread-chrome/node_modules/jscs/node_modules/prompt/node_modules/winston/test/fixtures/keys/agent2-key.pem'. You probably don't want to do that.

This only occurs during the development of my extension. But are those key files actively in use, and necessary for testing winston? If not, it would be nice to remove them.

@indexzero
Copy link
Member

They are needed in development but not in production. Can you help us by submitting a PR to fix it? You just need to:

  1. Copy the .gitignore to an .npmignore.
  2. Add these files to only the .npmignore
test/fixtures/keys/
test/transports/webhook-test.js

indexzero added a commit that referenced this issue Aug 28, 2015
Remove pem keys from production - Closes #701
nikolas added a commit to nikolas/prompt that referenced this issue Oct 5, 2015
Addresses this issue with bundled PEM keys in older versions of winston: winstonjs/winston#701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants