Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winston cannot render the Symbol type #805

Closed
tjwebb opened this issue Feb 13, 2016 · 1 comment · Fixed by #806
Closed

winston cannot render the Symbol type #805

tjwebb opened this issue Feb 13, 2016 · 1 comment · Fixed by #806

Comments

@tjwebb
Copy link
Contributor

tjwebb commented Feb 13, 2016 

Debug: internal, implementation, error
    TypeError: Uncaught error: Cannot convert a Symbol value to a string

see also: #668 (comment)
tjwebb added a commit to tjwebb/winston that referenced this issue Feb 13, 2016
@tjwebb
[fix] add support for es6 Symbol type.
eb90196 
- resolves winstonjs#805
@tjwebb tjwebb mentioned this issue Feb 13, 2016
Merged
@indexzero
Copy link
Member

Fixed in #806.

@indexzero indexzero reopened this Feb 20, 2016
gigabo added a commit to gigabo/react-server that referenced this issue Feb 25, 2016
@gigabo
Upgrade to latest winston
f0b11fa 
This is preparation for upgrading to the _next_ winston which introduces
support for logging react elements (which contain symbols) without choking.

winstonjs/winston#805
@gigabo gigabo mentioned this issue Feb 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] add support for es6 Symbol type. tjwebb/winston
2 participants
@indexzero @tjwebb