Ts updates #1625
Merged
Ts updates #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing handleExceptions boolean in LoggerOptions
It is valid for a user to pass `logger.info({some:object})` or the same `logger.log('info',{some:object})` (or even an array or error) and unfortunately that means we need to add an any type to this declaration.
(forgot previously)
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
* Update index.d.ts
Added missing handleExceptions boolean in LoggerOptions
* Add :any to logmethod and loglevelmethod
It is valid for a user to pass `logger.info({some:object})` or the same `logger.log('info',{some:object})` (or even an array or error) and unfortunately that means we need to add an any type to this declaration.
* Added Logger return method to declarations
(forgot previously)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is valid for a user to pass
logger.info({some:object})or the samelogger.log('info',{some:object})(or even an array or error) and unfortunately that means we need to add an any type to this declaration.