Update index.d.ts #1729
Merged
Update index.d.ts #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoist type defs from the logform module.
Currently there isn't a way to write correct type definitions for
when e.g creating a format since the types for such objects are
declared in `logform`.
This patch move logform type defs so that they can be used by
user code - For example by doing:
`import { Logform } from 'winston'; const f: Logform.Format;`
|
Good to see this has been merged, but when can we expect a release to include this?! @DABH |
|
Up to @indexzero ... |
Mizumaki
pushed a commit
to Mizumaki/winston
that referenced
this pull request
Jun 11, 2020
Hoist type defs from the logform module.
Currently there isn't a way to write correct type definitions for
when e.g creating a format since the types for such objects are
declared in `logform`.
This patch move logform type defs so that they can be used by
user code - For example by doing:
`import { Logform } from 'winston'; const f: Logform.Format;`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist type defs from the logform module.
Currently there isn't a way to write correct type definitions for
when e.g creating a format since the types for such objects are
declared in
logform.This patch move logform type defs so that they can be used by
user code - For example by doing:
import { Logform } from 'winston'; const f: Logform.Format;